Skip to content

Conversation

@ferr3ira-gabriel
Copy link
Member

@ferr3ira-gabriel ferr3ira-gabriel commented Dec 29, 2025

Changes

New Features

  • pr-security-scan: Added enable_docker_scan input to skip Docker-related steps for CLI projects without Dockerfiles
  • frontend-pr-analysis: New workflow for frontend projects

Documentation

  • Standardized all workflow documentation to use secrets: inherit pattern
  • Updated all examples to use blacksmith runners
  • Added required secrets notes where appropriate

Commits

8b7dac9 Merge pull request #65 from LerianStudio/feature/pr-security-scan-skip-docker
2360cd1 docs: update api-dog troubleshooting to use secrets: inherit
a0d6ede docs: standardize all workflow documentation to use secrets: inherit
a0ccaa7 docs: update pr-security-scan documentation
81b55a6 feat(pr-security-scan): add enable_docker_scan input

Summary by CodeRabbit

  • New Features

    • Optional Docker vulnerability scanning via configurable enable_docker_scan parameter.
    • New CLI/Non-Docker workflow option for projects not using containerization.
  • Chores

    • Simplified secret management across workflows using inherited secrets.
    • Updated default runner configurations for improved performance.
    • Enhanced documentation with clearer examples and best practices.

✏️ Tip: You can customize this high-level summary in your review settings.

ferr3ira-gabriel and others added 5 commits December 29, 2025 16:46
Add option to disable Docker image build and vulnerability scanning
for projects without Dockerfile (e.g., CLI tools).

When enable_docker_scan is false:
- Trivy filesystem secret scanning still runs
- Docker image build is skipped
- Docker vulnerability scanning is skipped

Also updated documentation with:
- New input description
- CLI/Non-Docker projects usage example
- Updated runner_type default to blacksmith
- Simplified secrets to use inherit

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Add CLI/Non-Docker support to features list
- Update workflow steps to show conditional Docker steps
- Update best practices with blacksmith runners and secrets inherit
- Update all examples to use secrets: inherit
- Update runner_type in examples to blacksmith-4vcpu-ubuntu-2404

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Updated all workflow documentation examples to use `secrets: inherit`
instead of explicit secret mappings. This simplifies secret management
and makes workflows more consistent.

Files updated:
- api-dog-e2e-tests-workflow.md
- gitops-update-workflow.md
- go-pr-analysis-workflow.md
- go-release-workflow.md
- pr-security-scan-workflow.md
- pr-validation-workflow.md
- release-workflow.md
- slack-notify-workflow.md

Added required secrets notes where appropriate to document which
secrets must be configured at the organization/repository level.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…p-docker

feat(pr-security-scan): add enable_docker_scan input for CLI projects
@coderabbitai
Copy link

coderabbitai bot commented Dec 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request implements two primary changes: (1) it introduces a new enable_docker_scan input to the pr-security-scan workflow that conditionally gates Docker Buildx setup, Docker image building, and Trivy vulnerability scanning steps based on a boolean flag (default true), and (2) it updates documentation across multiple workflow guides to replace explicit per-secret mappings with secrets: inherit, standardizing secret delivery to reusable workflows. Additionally, the pr-security-scan documentation reflects runner updates from firmino-lxc-runners to blacksmith-4vcpu-ubuntu-2404, and includes guidance for CLI/non-Docker scanning scenarios.

Possibly related PRs

  • PR #65: Adds the enable_docker_scan input to the pr-security-scan workflow with conditional Docker step execution, representing parallel or overlapping work
  • PR #36: Modifies the pr-security-scan workflow with runner type updates, affecting the same workflow's configuration
  • PR #47: Adds input-based conditional logic to the pr-security-scan workflow (paths_ignore input) for skipping scanning, demonstrating related gating patterns

Suggested labels

30 min review

Suggested reviewers

  • maciell1

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 966d65c and 8b7dac9.

📒 Files selected for processing (9)
  • .github/workflows/pr-security-scan.yml
  • docs/api-dog-e2e-tests-workflow.md
  • docs/gitops-update-workflow.md
  • docs/go-pr-analysis-workflow.md
  • docs/go-release-workflow.md
  • docs/pr-security-scan-workflow.md
  • docs/pr-validation-workflow.md
  • docs/release-workflow.md
  • docs/slack-notify-workflow.md

Comment @coderabbitai help to get the list of available commands and usage tips.

@ferr3ira-gabriel ferr3ira-gabriel merged commit 08614ee into main Dec 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants