Open
Conversation
coderdjw
requested changes
May 29, 2024
LeiQL
force-pushed
the
users/leqia/versioningsupportbasic
branch
2 times, most recently
from
beccb02 to
590f404
Compare
LeiQL
force-pushed
the
users/leqia/versioningsupportbasic
branch
from
590f404 to
10347af
Compare
LeiQL
force-pushed
the
users/leqia/versioningsupportbasic
branch
from
7a02189 to
b4b86ff
Compare
LeiQL
force-pushed
the
users/leqia/versioningsupportbasic
branch
from
3846d55 to
7ffe2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
ownerReferenceon the version object to support sync-back feature. Add guidance in resourcewebhook- if resource container doesn't exist, fail the request; otherwise, add ownerReference if container object exists.