Conversation
HandoA01
requested review from
baeys0619 and
gachaemin
and removed request for
gachaemin
gachaemin
requested changes
Jan 22, 2026
Contributor
gachaemin
left a comment
gachaemin
left a comment
There was a problem hiding this comment.
지금 앱크기로 그림자가 들어가있는데, 그건 제거해주시는게 좋을 것 같습니다!
gachaemin
approved these changes
Jan 23, 2026
baeys0619
approved these changes
Jan 23, 2026
| import { DUMMY_BOOKS } from "@/mocks/booklist.mock"; | ||
|
|
||
| export default function RoutinePage() { | ||
| const [activeTab, setActiveTab] = useState<"routine" | "statistics">("routine"); |
Collaborator
There was a problem hiding this comment.
union type을 사용함으로써 routine이나 statistics 중 하나로 타입을 지정해주셔서 에러 차단에 효과적일 것 같네용~ 이번에도 수고 많으셨습니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
설명
루틴의 독서 리스트 페이지를 구현하고,
Tab, BookList의 컴포넌트를 다소 수정하였습니다.
스크린샷
2026-01-23.3.22.52.mov
완료사항
관련이슈
closes #35
기타사항