[8주차] 조연준/[feat] Docker Compose & CI/CD#320
Open
yeonjuncho wants to merge 3 commits into
Hidden character warning
The head ref may contain hidden characters: "\uc870\uc5f0\uc900/8\uc8fc\ucc28"
Open
Conversation
LGH0507
approved these changes
May 28, 2026
LGH0507
left a comment
There was a problem hiding this comment.
mysql 포트와, 로컬 포트도 본인 환경에 맞게 잘 적용해서 과제 요구사항을 잘 수행하신 것 같습니다. 고생하셨습니다!
| restart: always | ||
| depends_on: | ||
| mysql: | ||
| condition: service_healthy |
There was a problem hiding this comment.
healthCheck 조건을 걸어 DB가 안정됐을 때 요청받을 수 있도록 잘 작성하신 것 같습니다👍
seejaewook456-maker
approved these changes
May 28, 2026
Comment on lines
+36
to
+38
| - name: Test | ||
| run: ./gradlew test | ||
|
|
There was a problem hiding this comment.
Gradle 테스트를 먼저 실행한 뒤 Docker 이미지를 빌드하는 흐름으로 잘 설계하신 것 같습니다. 고생 많으셨습니다!
ruchan04
approved these changes
May 28, 2026
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| outputs: |
There was a problem hiding this comment.
GitHub Secrets 설정 여부를 체크하여 can_deploy 출력을 만들고, 이를 조건문(if:)으로 활용해 배포 단계의 실행 여부를 동적으로 제어한 설계가 인상적입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
Dockerfile을 작성했습니다.docker-compose.yml을 작성했습니다.주요 변경 사항
Dockerfile
8081을 노출합니다.docker-compose.yml
mysql:8.0이미지 기반 MySQL 컨테이너를 구성했습니다.cicd.yml
docker compose pull,docker compose up -d를 실행합니다.실행 방법