fix(client-react): create WalletAPIClient once in WalletAPIProvider#574
Merged
Conversation
The provider created the client inside a `useState` initializer. Since the `WalletAPIClient` constructor has a side effect (it registers itself on `transport.onMessage`), React strict mode's double-invocation constructed a second, discarded client whose constructor hijacked the transport. Responses were then routed to a client with no pending requests, throwing `no ongoingRequest` — which broke the Next.js simulator example. Use the ref "create once" pattern so exactly one client is instantiated and remains the owner of the transport, even under strict mode. Also make the example's simulator flag detection more forgiving: `?simulator` (bare) now activates the simulator, not just `?simulator=true`.
🦋 Changeset detectedLatest commit: 4ac78e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider created the client inside a
useStateinitializer. Since theWalletAPIClientconstructor has a side effect (it registers itself ontransport.onMessage), React strict mode's double-invocation constructed a second, discarded client whose constructor hijacked the transport. Responses were then routed to a client with no pending requests, throwingno ongoingRequest— which broke the Next.js simulator example.Use the ref "create once" pattern so exactly one client is instantiated and remains the owner of the transport, even under strict mode.
Also make the example's simulator flag detection more forgiving:
?simulator(bare) now activates the simulator, not just?simulator=true.