Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 77.37% 77.16% -0.22%
==========================================
Files 36 36
Lines 2038 2054 +16
==========================================
+ Hits 1577 1585 +8
- Misses 461 469 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cedelavergne-ledger
force-pushed
the
cev/improve_golden_run_with_rm
branch
from
16d466f to
e2957f0
Compare
|
|
||
| if device.is_nano: | ||
| return NanoNavigator(backend, device, golden_run) | ||
| return NanoNavigator(backend, device, golden_run, rm_snap) |
Contributor
There was a problem hiding this comment.
Not a fan of adding such a specific parameter
Can we make golden_run a class with regen and rm as parameters ? And then move around the golden_run object?
cedelavergne-ledger
force-pushed
the
cev/improve_golden_run_with_rm
branch
2 times, most recently
from
50f66f8 to
966bae4
Compare
cedelavergne-ledger
force-pushed
the
cev/improve_golden_run_with_rm
branch
from
966bae4 to
250bf11
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new option parameter
--rmallowing to remove the existing snapshots before running testsThis optio is only usable when
--golden_runis also requestedThis allows to cleanup the useless snapshots