Fix Claims.add() default to preserve existing claims instead of replacing them #926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claims.add()was deleting all existing claims with the same property when adding a new claim, contrary to user expectations. The default behavior wasREPLACE_ALL, marking existing claims for removal on write.Changes
action_if_existsparameter inClaims.add()fromREPLACE_ALLtoAPPEND_OR_REPLACEaction_if_existsbehaviorsImpact
Before:
After:
Users wanting replace-all behavior can explicitly specify
action_if_exists=ActionIfExists.REPLACE_ALL. This alignsClaims.add()withBaseEntity.add_claims(), which already defaulted toAPPEND_OR_REPLACE.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
httpbin.org/home/REDACTED/.cache/pypoetry/virtualenvs/wikibaseintegrator-h1tmzOrO-py3.12/bin/python /home/REDACTED/.cache/pypoetry/virtualenvs/wikibaseintegrator-h1tmzOrO-py3.12/bin/pytest test/test_entity_item.py -v(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.