Add support for additional request parameters in login methods #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeMyst
force-pushed
the
add-requests-params-login
branch
from
83b7338 to
bcc7fab
Compare
LeMyst
force-pushed
the
add-requests-params-login
branch
from
bcc7fab to
bfd5b86
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing additional HTTP request parameters to login methods. The primary goal is to enable users to specify custom request parameters like proxies, headers, timeout settings, and SSL verification options when authenticating with MediaWiki instances.
Key changes:
- Enhanced
LoginandClientloginclasses to accept**kwargsparameters for HTTP requests - Added parameter filtering to only allow specific safe parameters (
headers,proxies,timeout,verify) - Added logging warnings for unsupported parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wikibaseintegrator/wbi_login.py | Added **kwargs support to Login and Clientlogin constructors with parameter filtering and validation |
| test/test_wbi_login.py | Added test for SSL verification functionality and modernized test assertions to use pytest.raises |
| test/test_wbi_helpers.py | Modernized test assertions from unittest.TestCase().assertRaises to pytest.raises |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.