Skip to content

chore: add mise.toml + root Makefile, refresh architecture docs#247

Open
ethenotethan wants to merge 3 commits into
masterfrom
add-mise-and-makefile
Open

chore: add mise.toml + root Makefile, refresh architecture docs#247
ethenotethan wants to merge 3 commits into
masterfrom
add-mise-and-makefile

Conversation

@ethenotethan
Copy link
Copy Markdown
Contributor

@ethenotethan ethenotethan commented May 29, 2026

Summary

  • Add mise.toml pinning Go 1.25, Node 22, Swift 6.1, Python 3.12 plus jq/gh/awscli/gcloud so every contributor lands on the same toolchain.
  • Add root Makefile wrapping the coordinator/provider/enclave/console-ui/e2e build+test commands previously listed as raw shell in AGENTS.md. make with no args lists targets.
  • Update AGENTS.md "Building And Testing" to point at both files and show the mise install + make <target> flow.
  • Refresh docs/ARCHITECTURE.md and remove dead files (docs/telemetry.md, tests/test_crypto_interop.py) so on-disk reality matches the docs. taken from closed loop docs

Test plan

  • mise trust && mise ls --current resolves every tool listed in mise.toml
  • make help lists all wrapped targets
  • make coordinator-test — all coordinator packages pass
  • make coordinator-build — produces coordinator/coordinator (Mach-O arm64)
  • make coordinator-build-linux — produces ELF x86-64 binary
  • make enclave-build + make enclave-test — 26 tests pass
  • make ui-install + make ui-lint — 0 errors
  • make ui-test — 141 vitest tests pass (under Node 22 from mise; host Node 18 breaks vitest, which is exactly why mise activation matters)
  • make ui-build — Next.js production build succeeds
  • go vet ./e2e/... — e2e targets are wired correctly
  • make provider-build blocked by uninitialized libs/mlx-swift submodule (pre-existing repo state, not introduced by this PR; raw swift build fails the same way — fixed by git submodule update --init --recursive)

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

ethenotethan and others added 2 commits May 29, 2026 22:19
Pins Go/Node/Swift/Python plus jq/gh/awscli/gcloud in mise.toml so
every contributor lands on the same toolchain, and wraps the
build/test commands from AGENTS.md in a root Makefile (coordinator,
provider, enclave, console-ui, e2e). AGENTS.md now points to both
and shows the mise install + make target invocation.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: d-inference.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
d-inference-console-ui-dev Ready Ready Preview May 29, 2026 4:47pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

No security-relevant changes: this PR modifies only documentation, build tooling, and developer tooling configuration, none of which touch a trust boundary or runtime code path.

Trust boundaries touched

None.

Threat coverage

No T-xxx threats are affected by this diff.

File-by-file notes

File Content New attack surface?
AGENTS.md AI agent instructions / contributor guidance No
Makefile Build targets and local dev helpers No — not executed at runtime; not part of the release artifact
docs/ARCHITECTURE.md Narrative architecture documentation No — static docs only
mise.toml Developer tool version pinning (mise version manager) No — dev tooling, not in the production binary or coordinator image

Threat model coverage gap

None of these files need to be added to the threat model's affected_files lists. They are build/dev-time artifacts only and do not execute in the coordinator, provider, or console-ui trust boundaries at runtime.

One thing worth confirming out-of-band (not a blocker): if Makefile targets are ever used inside a CI release pipeline that produces the provider binary or coordinator image, the affected_files for T-034 (BinaryHasher.swift, attestation chain) should eventually include the Makefile to ensure build-system changes get a security review pass. As of this diff that is not the case.

SEC-* findings resolved

None.


🔐 Threat model: docs/threat-model.yaml · Updates on each push to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: d-inference-landing.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants