ci: compact benchmark PR comments — summary table + artifact#170
Open
hankbobtheresearchoor wants to merge 2 commits into
Open
ci: compact benchmark PR comments — summary table + artifact#170hankbobtheresearchoor wants to merge 2 commits into
hankbobtheresearchoor wants to merge 2 commits into
Conversation
|
@hankbobtheresearchoor is attempting to deploy a commit to the EigenLabs Team on Vercel. A member of the Team first needs to authorize it. |
hankbobtheresearchoor
force-pushed
the
fix/compact-benchmark-comment
branch
5 times, most recently
from
4037d93 to
9243fe7
Compare
hankbobtheresearchoor
force-pushed
the
fix/compact-benchmark-comment
branch
from
9243fe7 to
eea2ba0
Compare
- Parse FULL latency decomposition (all segments, not just total_e2e) - Generate benchmark-results.csv with one row per scenario - CSV columns: sha, short_sha, timestamp, runner, scenario, config (providers/users/concurrency/streaming), aggregate metrics, per-segment P50/P95/mean/max, assertion status + details - Upload both CSV (text/csv) and markdown (text/markdown) to GCS - PR comment now links to both formats - CSV enables long-term cross-run analysis and synthesis
hankbobtheresearchoor
force-pushed
the
fix/compact-benchmark-comment
branch
from
add8029 to
7c5fcb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark comments currently dump the full raw markdown (scenario configs, per-segment latency tables, assertion details) into every PR, bloating the conversation and burying real review discussion.
Change: Replace the verbose comment with a compact summary table + upload the full results as a workflow artifact.
Before: ~3,000-character markdown dump per PR
After: One compact summary like:
Full benchmark markdown is uploaded as a workflow artifact (30-day retention) accessible from the run page.