deps: Bump CommunityToolkit.Mvvm from 8.4.0 to 8.4.2#1
Merged
Layellie merged 1 commit intoJun 28, 2026
Merged
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
5 tasks
Layellie
added a commit
that referenced
this pull request
Jun 26, 2026
#1 (critical bug): ProcessOptimizationService.cs:80 was calling SetProcessInformation with processInformationClass=34 — the exact typo that App.OnStartup already had fixed to 4. With 34 the call returns ERROR_INVALID_PARAMETER and IGNORE_TIMER_RESOLUTION never applies, so games added to Game Mode kept getting EcoQoS-throttled to 1–15.6 ms in the background, defeating the whole point of the 0.5 ms global lock for those processes. Replaced both call sites (this one and App.xaml.cs) with a new NativeMethods.ProcessPowerThrottling = 4 named constant so the magic number can't be re-introduced. #2: SettingsViewModel.ImportSettings now raises a SettingsImported event with the freshly loaded snapshot; MainViewModel subscribes and re-applies it via ApplySettings, so the running session updates without a restart. The localized "restart to apply" success string is now obsolete and reads just "Settings imported". #3: Removed dead code — MeasureActualResolutionMs is no longer called anywhere (the watchdog reads `current` directly from NtSetTimerResolution), and its three P/Invokes (GetSystemTimeAsFileTime, TimeBeginPeriod, TimeEndPeriod) went with it. The legacy timeBeginPeriod path had an explicit warning comment about why it must never be re-enabled. #4: ApplyTimerRequest used to register the *caller* thread as AVRT "Pro Audio" and drop the returned handle on the floor — that permanently boosted the dispatcher to MMCSS and leaked one handle per Activate cycle. The dedicated watchdog thread already does MMCSS registration AND reverts it on exit (handle stored in a local, AvRevertMmThreadCharacteristics called in finally), so the caller-thread call was both wrong (per-process kernel request, not per-thread) and leaky. Removed. #5: SyncMonitorSettings split into SyncMonitorThresholds (called on every TextBox keystroke) and SyncMonitorGames (called only when the Games collection mutates). Stops rebuilding the GamePaths list on every digit the user types into a threshold input. Bumped to 2.0.5 in csproj, Setup.iss and build-installer.ps1. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Owner
|
@dependabot rebase |
--- updated-dependencies: - dependency-name: CommunityToolkit.Mvvm dependency-version: 8.4.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/nuget/StandbyAndTimer/CommunityToolkit.Mvvm-8.4.2
branch
from
60c6a8b to
8a8a01c
Compare
Layellie
deleted the
dependabot/nuget/StandbyAndTimer/CommunityToolkit.Mvvm-8.4.2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated CommunityToolkit.Mvvm from 8.4.0 to 8.4.2.
Release notes
Sourced from CommunityToolkit.Mvvm's releases.
8.4.2
What's Changed
Full Changelog: CommunityToolkit/dotnet@v8.4.1...v8.4.2
8.4.1
This release of the .NET Community Toolkit updates the MVVM Toolkit analyzers and source generator to Roslyn 5.0, so they can work with C# 14 out of the box. This means that
[ObservableProperty]on partial properties no longer needspreviewlanguage version 🎉What's Changed 🆕
--no-buildargument in dotnet test invokation by @echoix in Remove extra dash in--no-buildargument in dotnet test invokation CommunityToolkit/dotnet#1132[ObservableProperty]by @Sergio0694 in Fix C# language version checks for[ObservableProperty]CommunityToolkit/dotnet#1140New Contributors
--no-buildargument in dotnet test invokation CommunityToolkit/dotnet#1132Full Changelog: CommunityToolkit/dotnet@v8.4.0...v8.4.1
Commits viewable in compare view.