modules/zathura: init#157
Open
aquifolly wants to merge 1 commit into
Open
Conversation
zimward
reviewed
May 14, 2026
aquifolly
force-pushed
the
push-yozxkpsoopvr
branch
2 times, most recently
from
e8d2205 to
1c3e187
Compare
aquifolly
force-pushed
the
push-yozxkpsoopvr
branch
from
1c3e187 to
38acda5
Compare
zimward
requested changes
May 15, 2026
| { | ||
| _class = "wrapper"; | ||
| options = { | ||
| options = lib.mkOption { |
Collaborator
There was a problem hiding this comment.
Suggested change
| options = lib.mkOption { | |
| settings = lib.mkOption { |
as per RFC42 and consistency with the other modules
| default.content = | ||
| lib.concatStringsSep "\n" ( | ||
| lib.optional (config.extraConfig != "") config.extraConfig | ||
| ++ lib.mapAttrsToList formatLine config.options |
Collaborator
There was a problem hiding this comment.
Suggested change
| ++ lib.mapAttrsToList formatLine config.options | |
| ++ lib.mapAttrsToList formatLine config.settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.