Domain validation and path#24
Open
Casey-Haseloff wants to merge 6 commits intoLanguage-Research-Technology:mainfrom
Open
Domain validation and path#24Casey-Haseloff wants to merge 6 commits intoLanguage-Research-Technology:mainfrom
Casey-Haseloff wants to merge 6 commits intoLanguage-Research-Technology:mainfrom
Conversation
benfoley
requested changes
Oct 20, 2025
Contributor
benfoley
left a comment
benfoley
left a comment
There was a problem hiding this comment.
Couple of suggestions and minor fixes
| {% endif %} | ||
|
|
||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:title" content="{{ data.ids[data.entryPoint].props["http://schema.org/name"].fwd[0].value if data.ids[data.entryPoint].props["http://schema.org/name"] }}" /> |
Contributor
There was a problem hiding this comment.
Might be safest to wrap both the name and description tags in conditions that only write the respective tags if there's content, rather than writing a tag with blank content. Same for the other templates.
| <meta name="description" content="{{ data.ids[data.entryPoint].props.sentence.fwd[0].value }}" /> | ||
| {% if data.ids[data.entryPoint].props["http://schema.org/hasPart"] %} | ||
| <meta property="og:title" content="{{ data.ids[data.entryPoint].props['http://schema.org/name'].fwd[0].value }}" /> | ||
| <meta property="og:description" content="{{ data.ids[data.entryPoint].props.sentence.fwd[0].value }}" /> |
Contributor
There was a problem hiding this comment.
This didn't work for me. Try replacing
data.ids[data.entryPoint].props.sentence.fwd[0].value with
data.ids[data.entryPoint].props['arcp://name,custom/terms#sentence'].fwd[0].value
similar for ln 11 below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.