[로또 게임] 박지현 2차 과제 제출합니다. #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2024 02:47
|
w지현💙 |
Collaborator
genius00hwan
left a comment
genius00hwan
left a comment
There was a problem hiding this comment.
전반적으로 MVC 구현을 잘해주었습니다. 다만 패키징도 나눠주는게 좀더 이해하기 편할것 같습니다.
| @@ -0,0 +1,30 @@ | |||
| package lotto; | |||
|
|
|||
| public class Exception { | |||
Collaborator
There was a problem hiding this comment.
이왕 Exception 클래스 만든거 Java의 RuntimeException 같은거 상속한번 받아보지 아쉽네요
| //당첨 통계 계산 | ||
| void produceStatistics() { | ||
| int bonusNumber = insert.getBonusNumber(); | ||
| StatisticsCalculator statisticsCalculator = new StatisticsCalculator(); |
Collaborator
There was a problem hiding this comment.
의존성이 있는 객체가 있다면 새로 생성할게 아니라 필드에 명시해두고 가져다 쓰는게 일반적입니다. 함수에서 생성하면 너무많이 생성될 수 도 있을것 같아요
|
|
||
| //당첨 내역과 수익률 | ||
| void printAll(int lottoPrice) { | ||
| Print print = new Print(); |
Collaborator
There was a problem hiding this comment.
마찬가지로 의존성관리를 좀더 공부해보세요
|
|
||
| import camp.nextstep.edu.missionutils.Console; | ||
| public class RunApplication { | ||
| void run() { |
Collaborator
There was a problem hiding this comment.
굉장히 맘에드는 함수입니다. 가독성이 훌륭합니다. 다만 클래스명이 좀 아쉽네요. 함수명이 단순히 run()이라면 클래스명이라도 좀더 직관적이었으면 좋겠어요.
| @@ -0,0 +1,31 @@ | |||
| package lotto; | |||
|
|
|||
| public enum WinningEnum { | |||
Collaborator
There was a problem hiding this comment.
enum을 잘활용했네요. 다만 enum 객체는 상수처럼 활용하려면 대문자로 사용하는 것이 일반적입니다. ex. THREE(),FOUR()..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.