Skip to content
This repository was archived by the owner on Feb 7, 2021. It is now read-only.

Cleaning up factories#27

Open
rarog wants to merge 1 commit intoLaminas-Commons:laminas-3.xfrom
rarog:master
Open

Cleaning up factories#27
rarog wants to merge 1 commit intoLaminas-Commons:laminas-3.xfrom
rarog:master

Conversation

@rarog
Copy link
Contributor

@rarog rarog commented Jul 16, 2020

  • Getting rid of old and unused methods used by laminas-servicemanager <
    3
  • Adjusting method signature of __invoke to be in sync with interface.

- Getting rid of old and unused methods used by laminas-servicemanager <
3
- Adjusting method signature of __invoke to be in sync with interface.
@matwright
Copy link
Member

matwright commented Jul 17, 2020

Thanks for this @rarog
The travis build is failing due to fatal errors in the test suite.
There is a separate ticket #28 for the unit test issues and once that is resolved we can test this PR again.

@matwright matwright changed the base branch from master to laminas-3.x July 25, 2020 15:18
@matwright matwright self-requested a review July 25, 2020 15:19
@matwright matwright self-assigned this Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants