Fix all LAP algorithms and add correctness CI (P0)#6
Merged
Conversation
Replace the broken algorithm implementations with a shared, correct O(n^3) shortest-augmenting-path solver and verify all six algorithms against scipy/lap reference solvers. Algorithms: - Add sap_solve + pad_to_square/trim_solution helpers in utils.rs - Rewrite lapjv, hungarian, lapmod, dantzig on top of sap_solve - Fix auction: correct the inverted (maximizing) sign so it minimizes cost - Fix subgradient: add SAP primal recovery after the dual phase Testing & CI: - Expand test_correctness.py to 42 tests covering all six algorithms, cross-algorithm agreement, and permutation validity - Add .github/workflows/ci.yml: fmt/clippy + pytest on Python 3.9-3.13, running on every push and pull request - Fix CI.yml version check to read Cargo.toml (pyproject uses dynamic version) Packaging: - Move maturin/twine/lap out of runtime deps into the dev group Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the broken algorithm implementations with a shared, correct O(n^3) shortest-augmenting-path solver and verify all six algorithms against scipy/lap reference solvers.
Algorithms:
Testing & CI:
Packaging: