This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Conversation
NoirHare
requested review from
a user,
Decrabbityyy,
Executor-Cheng,
KusaGumina,
Linwenxuan04,
Copilot,
pk5ls20 and
sisi0318
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue in forwarding private chat messages by adjusting the condition for including additional information.
- Reverses the condition on ClientSequence in ForwardEntity.cs to trigger additional packing when ClientSequence equals zero.
Comments suppressed due to low confidence (1)
Lagrange.Core/Message/Entity/ForwardEntity.cs:66
- The condition was reversed from 'ClientSequence != 0' to 'ClientSequence == 0'. Please confirm that this change correctly reflects the intended logic for including additional information in private chat forwarding.
if (additional && ClientSequence == 0)
ghost
approved these changes
May 21, 2025
Decrabbityyy
approved these changes
May 21, 2025
NoirHare
deleted the
darkrrb/fix/private-chat-Forward-with-additional-information
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.