Skip to content

add arrow csr dst col name param#534

Merged
adsharma merged 1 commit into
LadybugDB:mainfrom
aheev:add-dst-col-name
May 28, 2026
Merged

add arrow csr dst col name param#534
adsharma merged 1 commit into
LadybugDB:mainfrom
aheev:add-dst-col-name

Conversation

@aheev
Copy link
Copy Markdown
Contributor

@aheev aheev commented May 28, 2026

Adds support for custom destination column names in Arrow CSR relationship tables.

Previously, CSR-backed relationship tables required the indices Arrow table to contain a destination offset column named to. This change adds a dst_col_name parameter to the C API/internal Arrow CSR creation path so callers can use a different column name, while preserving "to" as the default when no name is provided.

@aheev
Copy link
Copy Markdown
Contributor Author

aheev commented May 28, 2026

@aheev
Copy link
Copy Markdown
Contributor Author

aheev commented May 28, 2026

@adsharma could you PTAL?

@adsharma
Copy link
Copy Markdown
Contributor

ladybug-nodejs needs an update too. We can deal with the rest later.

I'm looking into the pre-existing capi test failure. You can ignore that segfault for now.

@adsharma adsharma self-requested a review May 28, 2026 05:07
@aheev
Copy link
Copy Markdown
Contributor Author

aheev commented May 28, 2026

nodejs PR: LadybugDB/ladybug-nodejs#19

@adsharma adsharma merged commit 5051b0d into LadybugDB:main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants