Skip to content

Fix hash PK rollback after failed COPY #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
May 26, 2026
Merged

Fix hash PK rollback after failed COPY #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/include/storage/index/hash_index.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ class PrimaryKeyIndex final : public Index {
}

void delete_(common::ValueVector* keyVector);
void discardPrimaryKey(common::ValueVector* keyVector) override { delete_(keyVector); }
void discardPrimaryKey(common::ValueVector* keyVector) override;

void checkpointInMemory() override;
void checkpoint(main::ClientContext*, storage::PageAllocator& pageAllocator) override;
Expand Down
17 changes: 17 additions & 0 deletions src/storage/index/hash_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,23 @@ void PrimaryKeyIndex::delete_(ValueVector* keyVector) {
[](auto) { UNREACHABLE_CODE; });
}

void PrimaryKeyIndex::discardPrimaryKey(ValueVector* keyVector) {
DASSERT(indexInfo.keyDataTypes.size() == 1);
TypeUtils::visit(
indexInfo.keyDataTypes[0],
[&]<IndexHashable T>(T) {
for (auto i = 0u; i < keyVector->state->getSelVector().getSelSize(); i++) {
auto pos = keyVector->state->getSelVector()[i];
if (keyVector->isNull(pos)) {
continue;
}
auto key = keyVector->getValue<T>(pos);
discardLocal(key);
}
},
[](auto) { UNREACHABLE_CODE; });
}

void PrimaryKeyIndex::checkpointInMemory() {
bool indexChanged = false;
for (auto i = 0u; i < NUM_HASH_INDEXES; i++) {
Expand Down
Loading