feat: extract SDK types into types.ts and fix CI workflow#28
Merged
wumibals merged 1 commit intoMay 10, 2026
Merged
Conversation
- Extract Tier, Network, YieldLadderOptions, Position from index.ts into a dedicated sdks/typescript/src/types.ts - Re-export all types from index.ts for backwards compatibility - Add pnpm-lock.yaml for the SDK package - Fix CI: add pnpm cache (cache: pnpm + cache-dependency-path) to app and sdk jobs; switch both to --frozen-lockfile closes LadderMine#14
|
@Hassan-oladipupo is attempting to deploy a commit to the wumibals' projects Team on Vercel. A member of the Team first needs to authorize it. |
wumibals
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14.
Changes
sdks/typescript/src/types.ts(new): extractedTier,Network,YieldLadderOptions, andPositiontypes fromindex.tsinto a dedicated file.sdks/typescript/src/index.ts: re-exports all four types from./typesfor full backwards compatibility; imports them locally for class usage.sdks/typescript/pnpm-lock.yaml(new): committed lockfile so CI can run--frozen-lockfile..github/workflows/ci.yml: fixed two workflow bugs:cache: 'pnpm'+cache-dependency-pathto bothappandsdkjobs (previously no caching, causing fresh downloads on every run).--no-frozen-lockfileto--frozen-lockfilefor reproducible installs.Tested
pnpm typecheckpasses locally insdks/typescript.