Skip to content

fix(auth): fix auth module bugs, add transactions, clean up scrap code#255

Open
ayeshakhalid192007-dev wants to merge 1 commit into
LadderMine:mainfrom
ayeshakhalid192007-dev:feat/fix-auth-module-bugs
Open

fix(auth): fix auth module bugs, add transactions, clean up scrap code#255
ayeshakhalid192007-dev wants to merge 1 commit into
LadderMine:mainfrom
ayeshakhalid192007-dev:feat/fix-auth-module-bugs

Conversation

@ayeshakhalid192007-dev
Copy link
Copy Markdown

Summary

  • Fixed auth module bugs: added null check for restaurant relation during login, wrapped admin registration in a database transaction for atomicity
  • Cleaned up codebase: removed duplicate harouns-ux/ and unused scrap-menu/ modules, registered all feature modules in AppModule with rate limiting (ThrottlerModule)
  • Fixed frontend issues: corrected admin-registration route typo, updated API client

Test plan

  • Verify admin login works when restaurant relation is missing (should return proper error)
  • Verify admin registration creates both restaurant and admin atomically
  • Verify rate limiting is active on API endpoints
  • Verify frontend login and admin registration pages work correctly

🤖 Generated with Claude Code

- Fix null check on restaurant relation during login
- Wrap admin registration in a database transaction for atomicity
- Register feature modules in AppModule and add rate limiting (ThrottlerModule)
- Remove duplicate harouns-ux/ and unused scrap-menu/ modules
- Fix admin-registration route typo and update frontend API client

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ayeshakhalid192007-dev
Copy link
Copy Markdown
Author

Fixed auth module bugs — added a null check for the restaurant relation during login and wrapped admin registration in a database transaction to ensure atomicity. Cleaned up the codebase by removing duplicate harouns-ux/ and unused scrap-menu/ modules, and registered all feature modules in AppModule with rate limiting via ThrottlerModule. Fixed frontend issues — corrected the admin-registration route typo and updated the API client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants