Skip to content

GitHub Issue 717: Reserve fields from ExpDataTable in DataClassDomainKind #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 3 commits into from
Jan 7, 2026
Merged

GitHub Issue 717: Reserve fields from ExpDataTable in DataClassDomainKind #2836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2573bda
GitHub Issue 717: Reserve fields from ExpDataTable in DataClassDomain…
labkey-susanh Jan 5, 2026
c5c9067
Also reserve fields from ExpDataClassTable (to mirror what we do for …
labkey-susanh Jan 6, 2026
f9b94a4
Merge remote-tracking branch 'origin/develop' into fb_moreReservations
labkey-susanh Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/org/labkey/test/tests/DataClassTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,20 @@ public void testReservedFieldNames()
"'name' is a reserved field name in 'Reserved Field Names Test'.",
"Please correct errors in Reserved Field Names Test before saving."),
createPage.clickSaveExpectingErrors());
domainFormPanel.removeAllFields(false);

domainFormPanel.manuallyDefineFields("protocol");
assertEquals("Data class reserved field name error", Arrays.asList(
"'protocol' is a reserved field name in 'Reserved Field Names Test'.",
"Please correct errors in Reserved Field Names Test before saving."),
createPage.clickSaveExpectingErrors());
domainFormPanel.removeAllFields(false);

domainFormPanel.manuallyDefineFields("Name Expression");
assertEquals("Data class reserved field name error", Arrays.asList(
"'Name Expression' is a reserved field name in 'Reserved Field Names Test'.",
"Please correct errors in Reserved Field Names Test before saving."),
createPage.clickSaveExpectingErrors());

createPage.clickCancel();
}
Expand Down