Skip to content

Issue 52485: App admins can create and edit shorturls but can't view #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 1 commit into from
May 19, 2025
Merged

Issue 52485: App admins can create and edit shorturls but can't view #2454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/org/labkey/test/tests/core/admin/ShortUrlTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,15 @@ public void testShortUrlPermissions()
log("As app admin, update shortUrl created by another user");
adminPage.submitShortUrl(shortUrl_a, targetUrl2);

// Issue #52485 "App admins can create and edit shorturls but can't view them"
assertElementPresent(BootstrapLocators.errorBanner.withText("Table or query not found: ShortURL"));
// Issue #52485 "App admins can create and edit shorturls but can't view them" (but now they can!)
verifyShortUrlsInGrid(shortUrl_a, targetUrl2, shortUrl_b);
});

verifyShortUrlsInGrid(shortUrl_a, targetUrl2, shortUrl_b);
}

private void verifyShortUrlsInGrid(String shortUrl_a, String targetUrl2, String shortUrl_b)
{
Assertions.assertThat(ShortUrlAdminPage.beginAt(this).getUrlsFromGrid())
.as("short URLs")
.containsAllEntriesOf(Map.of(
Expand Down