Chris misc issues#2453
Merged
labkey-chrisj merged 38 commits intodevelopfrom Jun 5, 2025
Merged
Conversation
labkey-chrisj
commented
May 28, 2025
Contributor
Author
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
Some comments to make this PR more readable
labkey-chrisj
requested review from
labkey-danield,
labkey-jeckels and
labkey-tchad
labkey-tchad
requested changes
May 28, 2025
# Conflicts: # src/org/labkey/test/components/ui/grids/ResponsiveGrid.java
Co-authored-by: Trey Chadick <tchad@labkey.com>
Co-authored-by: Trey Chadick <tchad@labkey.com>
labkey-tchad
approved these changes
May 29, 2025
labkey-danield
requested changes
May 29, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Can you point to a TC run?
The banner test is failing for me locally.
labkey-danield
requested changes
May 29, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
The AdminConsoleTest.testSiteBannerAPIConfiguration is failing because the banner is not showing the INJECT_CHARS_1, which is probably by design. If so the test needs to check for the expected message.
The GridPanelViewTest.testWarningOnInvalidDateFilter is missing a step necessary for the repro.
Contributor
The site banner accepts HTML (hence the "Message HTML" label for the field Site Settings) so it's not a good candidate for |
Contributor
Author
labkey-danield
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Covers test automation for Misc. Issues Needs Automation github issue https://github.com/LabKey/kanban/issues/640
Related Pull Requests
n/a
Changes
new tests