clean up the right schema this time#2452
Merged
labkey-chrisj merged 1 commit intodevelopfrom May 19, 2025
Merged
Conversation
labkey-danield
approved these changes
May 19, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Since this was failing on TeamCity it would be useful to add a pointer to a TC run showing this does fix the issue.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Recently, LinkedSchemaTest.testCoreLinkedSchemaFilters has been failing because at the end of the test where it should be cleaning up the schema it created in the current test, it's cleaning up another one 🤦
Related Pull Requests
n/a
Changes
clean up the schema created in this test case, not the other