Skip to content

Wait for specialty assays to load#2432

Merged
labkey-tchad merged 1 commit intorelease25.3-SNAPSHOTfrom
25.3_fb_waitForSpecialtyAssays
May 8, 2025
Merged

Wait for specialty assays to load#2432
labkey-tchad merged 1 commit intorelease25.3-SNAPSHOTfrom
25.3_fb_waitForSpecialtyAssays

Conversation

@labkey-tchad
Copy link
Copy Markdown
Member

Rationale

Issue 52921: Longstanding intermittent test failure involving ChooseAssayTypePage
This helper seems to click the "Specialty Assay" tab before the page is ready and it stays on the "Standard Assay" tab.
Hopefully, waiting for the assay selector to load will be sufficient to ensure that the test can select the tab.

TeamCity failure state:
image

org.openqa.selenium.TimeoutException: Expected condition failed: waiting for visibility of [[[[[[FirefoxDriver: firefox on windows (79cd1de2-310d-41bb-a24c-419415cc7374)] -> xpath: ((.//*[@id="assay-picker-tabs"])|(.//*[contains(concat(' ',normalize-space(@class),' '), " lk-tabs ")]))]] -> xpath: (div|div/div)[contains(concat(' ',normalize-space(@class),' '), " tab-content ")]]] -> id: tabs0-pane-specialty] (tried for 10 second(s) with 500 milliseconds interval)
  at app//org.openqa.selenium.support.ui.WebDriverWait.timeoutException(WebDriverWait.java:84)
  at app//org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:228)
  at app//org.labkey.test.components.react.Tabs.selectTab(Tabs.java:67)
  at app//org.labkey.test.pages.assay.ChooseAssayTypePage.selectAssayType(ChooseAssayTypePage.java:65)
  at app//org.labkey.test.util.AbstractAssayHelper.createAssayDesign(AbstractAssayHelper.java:84)
  at app//org.labkey.test.util.AbstractAssayHelper.createAssayDesignWithDefaults(AbstractAssayHelper.java:72)
  at app//org.labkey.test.util.external.labModules.LabModuleHelper.defineAssay(LabModuleHelper.java:71)

Related Pull Requests

  • N/A

Changes

  • Wait for specialty assays to load

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team April 29, 2025 23:05
Copy link
Copy Markdown
Contributor

@labkey-chrisj labkey-chrisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@labkey-tchad labkey-tchad merged commit ab776b9 into release25.3-SNAPSHOT May 8, 2025
4 checks passed
@labkey-tchad labkey-tchad deleted the 25.3_fb_waitForSpecialtyAssays branch May 8, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants