Skip to content

EditableGridTest: Disable the test cases that drag fill multiline column values#2425

Merged
labkey-alan merged 2 commits intorelease25.4-SNAPSHOTfrom
25.4_fb_disable_multiline_drag_fill_tests
Apr 23, 2025
Merged

EditableGridTest: Disable the test cases that drag fill multiline column values#2425
labkey-alan merged 2 commits intorelease25.4-SNAPSHOTfrom
25.4_fb_disable_multiline_drag_fill_tests

Conversation

@labkey-alan
Copy link
Copy Markdown
Contributor

@labkey-alan labkey-alan commented Apr 23, 2025

Rationale

This PR disables the test cases in EditableGridTest that drag fill a column with a multiline text value. Our drag fill code now uses our paste handling code (in order to reduce complexity, and in order to address other issues with drag fill), but unfortunately we cannot handle pasting multiline text fields. See Issues 52226, 51927, which are slated to be fixed in 25.7.

Related Pull Requests

Changes

  • EditableGridTest: Disable the test cases that drag fill multiline column values

@labkey-alan labkey-alan self-assigned this Apr 23, 2025
@labkey-alan labkey-alan changed the base branch from develop to release25.4-SNAPSHOT April 23, 2025 21:34
@github-actions
Copy link
Copy Markdown

ERROR: A pull request from 25.4_fb_disable_multiline_drag_fill_tests is expected to target release25.4-SNAPSHOT, not develop

@labkey-alan labkey-alan changed the title EditableGridTest: Disable the tests that drag fill multiline column v… EditableGridTest: disable multiline drag fill tests Apr 23, 2025
@labkey-alan labkey-alan changed the title EditableGridTest: disable multiline drag fill tests EditableGridTest: Disable the test cases that drag fill multiline column values Apr 23, 2025
Copy link
Copy Markdown
Contributor

@labkey-danield labkey-danield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a @ignore annotation as well. The @ignore annotation will list the test if you run it locally so you see that it was ignored.
But this fix will achieve the desired result on TeamCity.

@labkey-alan labkey-alan merged commit b07bcf1 into release25.4-SNAPSHOT Apr 23, 2025
1 of 2 checks passed
@labkey-alan labkey-alan deleted the 25.4_fb_disable_multiline_drag_fill_tests branch April 23, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants