Reduce logging for exporting large folder archives#7649
Merged
labkey-jeckels merged 3 commits intorelease26.3-SNAPSHOTfrom May 7, 2026
Merged
Reduce logging for exporting large folder archives#7649labkey-jeckels merged 3 commits intorelease26.3-SNAPSHOTfrom
labkey-jeckels merged 3 commits intorelease26.3-SNAPSHOTfrom
Conversation
labkey-susanh
approved these changes
May 6, 2026
| { | ||
| this(relativizedLSIDs, selection.createURLRewriter(), user, container); | ||
| _log = log; | ||
| this(relativizedLSIDs, selection.createURLRewriter(), user, container, log); |
Contributor
There was a problem hiding this comment.
Should there be a @NotNull on the Logger argument here?
Contributor
Author
There was a problem hiding this comment.
Good point. I switched to use the default logger when null is passed. That's a small behavior change but should be reasonable given that almost everything has moved to debug level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Exporting a folder archive with many samples or other experiment objects can result in thousands or hundreds of thousands of not very interesting log entries.
Changes
DEBUGXarExporterTasks 📍
Manual TestingTest Automation