Move "limit unsuccessful logins" settings to core#7645
Open
labkey-adam wants to merge 10 commits intodevelopfrom
Open
Move "limit unsuccessful logins" settings to core#7645labkey-adam wants to merge 10 commits intodevelopfrom
labkey-adam wants to merge 10 commits intodevelopfrom
Conversation
labkey-nicka
approved these changes
May 7, 2026
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good. Couple comments and I sent you a patch for client-side changes/feedback.
| User user = context.getUpgradeUser(); | ||
|
|
||
| // TODO: change saveAuthSetting() visibility back to private after deleting this upgrade code | ||
| if (enabledVal != null) |
Contributor
There was a problem hiding this comment.
Should these mutations be transacted together?
| @@ -0,0 +1,2 @@ | |||
| -- Migrate login attempt settings from the compliance module's property store to core authentication settings. | |||
| SELECT core.executeJavaUpgradeCode('migrateLoginAttemptSettings'); | |||
Contributor
There was a problem hiding this comment.
Should we consider an upgrade test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Some IT security teams think this is a very important setting to have. https://github.com/LabKey/internal-issues/issues/907
Related Pull Request