Quantity support for volume and mass units and conversion between them #6918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(just working here, not for 24.11)
…s conversion more consistent in a bunch of places. ColumnRenderProperties.getConvertFn()
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
cnathe
changed the title
XingY
reviewed
Aug 14, 2025
|
|
||
| if (null != expr && expr.canRender(ctx.getFieldMap().keySet())) | ||
| { | ||
| // TODO handle Quantity values here? |
Contributor
There was a problem hiding this comment.
When there is a format we need to convert to defaultDisplayUnit() before calling .format()
| { | ||
| try | ||
| { | ||
| if (PropertyType.FILE_LINK.equals(col.getPropertyType()) && value instanceof String strVal) |
Contributor
There was a problem hiding this comment.
I see this if FileLine else block repeated a few times. Now that we have the col.getConvertFn() mechanism to handle conversion, could the FileLink check be handled as part of it?
Contributor
There was a problem hiding this comment.
Maybe??? I like the idea, if the FILE_LINK case is handled consistently in the various code paths. I don't know if that is true.
XingY
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This pull request introduces support for handling columns with quantity units by recognizing a special unit suffix in column names, updating formatting and conversion logic, and enhancing how units are displayed in the UI. The changes are focused on enabling a feature flag for quantity column suffixes, updating value formatting to handle units, and ensuring proper data conversion and display.
Related Pull Requests
Changes
__<unit>suffix when theQUANTITY_COLUMN_SUFFIX_TESTINGfeature is enabled