Skip to content

Conversation

@labkey-klum
Copy link
Contributor

@labkey-klum labkey-klum commented May 21, 2025

Rationale

Previously, the study design features (and schema) were behind a deprecated features flag. This work will move most (but not all) code into a new module : StudyDesign so that it can be added to the distribution of the single client which uses this feature.

The overall strategy was to move as much code into the new module as reasonably possible, create/use new interfaces to replace direct access to study classes, and for all others just use the active module to expose/hide functionality. Existing tests which exercised study design functionality should be fixed in this or related PRs.

Related Pull Requests

Changes

  • New StudyDesign module .
  • Web Parts and web resources moved to the new module.
  • A few treatment and assay schedule unit tests moved.
  • StudyDesignController moved.
  • The schema still remains in the study module but is exposed based on the active module.
  • Study design related writers and importers couldn't be easily moved, they remain in the study module but will noop if the module is not active. Due to the way internal study writers/importers are registered, I couldn't find an easy way to hide them in the import/export options for a container, this is unfortunate but seems harmless.

@cnathe
Copy link
Contributor

cnathe commented May 22, 2025

@labkey-klum I finished manual testing. I verified study export and publish with and without the studydesign module deployed to my localhost server.

The only thing I noticed is that the study schema looks to show the AssaySpecimen and AssaySpecimenVisit tables always. I believe those are part of the StudyDesign set of tables. It looks like the folder writers/importers for those tables are within the AssayScheduleImporter/AssayScheduleWriter and the tableInfo is in StudyDesignSchema. Should those be moved into the StudyDesignQuerySchema?

@labkey-klum labkey-klum merged commit b61064a into develop May 23, 2025
8 of 9 checks passed
@labkey-klum labkey-klum deleted the fb_issue_51726 branch May 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants