-
Notifications
You must be signed in to change notification settings - Fork 7
Move study design features into a new module #6686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@labkey-klum I finished manual testing. I verified study export and publish with and without the studydesign module deployed to my localhost server. The only thing I noticed is that the study schema looks to show the |
Rationale
Previously, the study design features (and schema) were behind a deprecated features flag. This work will move most (but not all) code into a new module :
StudyDesignso that it can be added to the distribution of the single client which uses this feature.The overall strategy was to move as much code into the new module as reasonably possible, create/use new interfaces to replace direct access to study classes, and for all others just use the active module to expose/hide functionality. Existing tests which exercised study design functionality should be fixed in this or related PRs.
Related Pull Requests
Changes
StudyDesignmodule .Web Partsand web resources moved to the new module.StudyDesignControllermoved.noopif the module is not active. Due to the way internal study writers/importers are registered, I couldn't find an easy way to hide them in the import/export options for a container, this is unfortunate but seems harmless.