Issue 53027: Cannot insert a row into a sample type if Allowed File Extensions set, no file is provided#6673
Closed
labkey-jeckels wants to merge 2 commits intodevelopfrom
Closed
Issue 53027: Cannot insert a row into a sample type if Allowed File Extensions set, no file is provided#6673labkey-jeckels wants to merge 2 commits intodevelopfrom
labkey-jeckels wants to merge 2 commits intodevelopfrom
Conversation
…xtensions are set and no file is provided
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
Are there tests that need to be added in conjunction with this?
| } | ||
| catch (IOException e) | ||
| { | ||
| throw new UnauthorizedException(e.getMessage()); |
Contributor
There was a problem hiding this comment.
UnauthorizedException seems not quite right here. Perhaps InvalidFileException would be better?
Contributor
Author
There was a problem hiding this comment.
We need something that's a RuntimeException and skips mothership logging. I introduced a new subclass of ApiUsageException
Contributor
Author
I renamed to match the branch name where Dan's adding test coverage and found this bug. New PR: #6677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We are being too picky about file uploads.
Changes