Issue 51979: BadSqlGrammarException indexing sample types immediately after a field rename#6611
Issue 51979: BadSqlGrammarException indexing sample types immediately after a field rename#6611
Conversation
… after a field rename
| /** returns null if the parent container is no longer available */ | ||
| @Nullable | ||
| public WebdavResource createIndexDocument() | ||
| public WebdavResource createIndexDocument(ExpMaterialTableImpl tableInfo) |
There was a problem hiding this comment.
Mark as @Nullable ExpMaterialTableImpl tableInfo
| }); | ||
| } | ||
|
|
||
| public void processIndexValues( |
There was a problem hiding this comment.
Consider making this protected.
| tableInfo = (ExpMaterialTableImpl) QueryService.get().getUserSchema(User.getSearchUser(), container, SCHEMA_SAMPLES).getTable(getSampleType().getName()); | ||
|
|
||
| if (tableInfo != null) | ||
| getCustomIndexValues(props, tableInfo, jsonData); |
There was a problem hiding this comment.
Should this be passing through the maps like ExpDataImpl does?
There was a problem hiding this comment.
Good point. Updated to pass in identifiersHi map. The other maps are not needed at the moment.
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Looks good from my manual testing.
One thing I noticed though; field renames aren't included in a sample's audit timeline. Maybe they should be?
Field renames are included in the Domain Property Events, which are, indeed, not pulled into the sample's timeline. Please open a separate issue and assign to triage to assess whether we need to do anything additional about this auditing. |
# Conflicts: # experiment/src/org/labkey/experiment/api/AbstractRunItemImpl.java
4 participants
Rationale
Issue 51979: BadSqlGrammarException indexing sample types immediately after a field rename
Issue 52961: DataClass: Integer fields are not index for data class, unlike sample types
Related Pull Requests
Changes