Issue 52728: LKSM: Update from file with duplicate rows is only updating once.#6571
Merged
Issue 52728: LKSM: Update from file with duplicate rows is only updating once.#6571
Conversation
| @Override | ||
| public List<Map<String, Object>> updateRows(User user, Container container, List<Map<String, Object>> rows, List<Map<String, Object>> oldKeys, BatchValidationException errors, @Nullable Map<Enum, Object> configParameters, Map<String, Object> extraScriptContext) | ||
| throws InvalidKeyException, BatchValidationException, QueryUpdateServiceException, SQLException | ||
| throws InvalidKeyException, BatchValidationException, QueryUpdateServiceException, SQLException // TODO |
| assertEquals("THREE", rows.get(3).get("s")); | ||
| assertNull(rows.get(3).get("i")); | ||
|
|
||
| // merge should fail if duplicate keys are provided |
Contributor
There was a problem hiding this comment.
Issue reference here?
labkey-susanh
approved these changes
Apr 22, 2025
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
Looks like there's still a lingering TODO in SpecimenUpdateService. Is that meant for this PR? I'll approve, but let me know if you want re-review for any change there (not that I know much about that service).
Contributor
Author
I've removed that stale TODO. thanks for pointing out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes
updateRowin various QUS so the same rows cannot be updated in the same updateRows callExistingRecordDataIteratorto check for previously seen keys so the same rows are not provided during update/merge