Automatic Hit Selection #6123
Merged
Automatic Hit Selection #6123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
labkey-nicka
force-pushed
the
fb_auto_hits
branch
from
c914ec8 to
3586d7f
Compare
labkey-nicka
force-pushed
the
fb_auto_hits
branch
from
1f891ad to
9ebd3d1
Compare
labkey-klum
reviewed
Dec 12, 2024
labkey-klum
reviewed
Dec 12, 2024
| } | ||
|
|
||
| @Override | ||
| public Map<String, List<GWTPropertyDescriptor>> previewFilterCriteriaColumns(@NotNull ExpProtocol protocol, List<String> columnNames) |
Contributor
There was a problem hiding this comment.
The list of column names passed in assume that they are candidates for replicate stats (numeric measures). Does the list get filtered / validated on the client side, or is it possible to create replicate stats for a string field?
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
This looks fine to me from me in terms of Lombok usage.
labkey-klum
reviewed
Dec 12, 2024
assay/src/org/labkey/assay/plate/AssayPlateMetadataServiceImpl.java
Outdated
Show resolved
Hide resolved
labkey-klum
reviewed
Dec 12, 2024
| .stream() | ||
| .filter(state -> !stateManager.isOperationPermitted(state, PlateDataStateManager.DataOperation.hitSelection)) | ||
| .map(DataState::getRowId) | ||
| .toList(); |
Contributor
There was a problem hiding this comment.
You can probably just get the set of the DataState row IDs.
labkey-klum
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
labkey-alan
force-pushed
the
fb_auto_hits
branch
2 times, most recently
from
f0c379c to
3ba10d9
Compare
labkey-alan
force-pushed
the
fb_auto_hits
branch
from
6202ae9 to
d09c22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This introduces the capability for automatic plate-based assay result hit selection based on filter criteria. Filter criteria are specified on assay result domain properties and are subsequently utilized to filter upon assay results when inserted/updated to determine if any should be marked as hits.
Related Pull Requests
Changes
filterCriteriato property descriptors and add CRUD support for themassay-filterCriteriaColumns.apito assist with retreival of column metadata for columns that are/to be generatedassay.FilterCriteriatable@labkey/components