Skip to content

Add forUpdate parameter to more methods that are getting domains #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 2 commits into from
Jun 4, 2025
Merged

Add forUpdate parameter to more methods that are getting domains #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5b79b
Add forUpdate parameter to more methods that are getting domains
labkey-susanh May 26, 2025
4a2cf57
Still more forUpdate parameters
labkey-susanh May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ehr/src/org/labkey/ehr/EHRManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ public List<String> ensureDatasetPropertyDescriptors(Container c, User u, boolea
messages.add("Missing property \"" + pd.getName() + "\" on dataset: " + dataset.getName() + ". Needs to be created.");
if (commitChanges)
{
domain = dataset.getDomain(true);
DomainProperty d = domain.addProperty();
d.setPropertyURI(pd.getPropertyURI());
d.setRangeURI(pd.getRangeURI());
Expand Down
3 changes: 1 addition & 2 deletions snd/src/org/labkey/snd/query/PackagesTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.labkey.api.data.Container;
import org.labkey.api.data.ContainerFilter;
import org.labkey.api.data.DbScope;
import org.labkey.api.data.JdbcType;
import org.labkey.api.data.SQLFragment;
Expand Down Expand Up @@ -150,7 +149,7 @@ public List<Map<String, Object>> insertRows(User user, Container container, List

try
{
DomainUtil.createDomain(PackageDomainKind.getPackageKindName(), newDomain, null, container, user, null, null);
DomainUtil.createDomain(PackageDomainKind.getPackageKindName(), newDomain, null, container, user, null, null, false);
}
catch (ValidationException ve)
{
Expand Down