Skip to content

Reference security-category table columns by header text #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-chrisj merged 2 commits into from
Oct 1, 2025
Merged

Reference security-category table columns by header text #1052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7503c4
Reference security-category table columns by header text
labkey-chrisj Sep 30, 2025
c34a4cf
provide useful error/screenshot if column is not found
labkey-chrisj Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions snd/test/src/org/labkey/test/tests/snd/SNDTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
import org.labkey.test.util.SqlserverOnlyTest;
import org.labkey.test.util.StudyHelper;
import org.labkey.test.util.core.webdav.WebDavUploadHelper;
import org.openqa.selenium.support.ui.ExpectedConditions;

import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -2121,6 +2122,18 @@ private void runTestsInAPIFrameWork()
assertTextPresent("Complete","Failed tests: 0");
}

private int getPermissionTableColumnIndex(String column)
{
var headersLoc = Locator.id("category-security").descendant(Locator.tagWithClass("th", "group-hdr"));
var columnHeaders = getTexts(headersLoc.findElements(getDriver()));
checker().withScreenshot("column_not_found").fatal()
.wrapAssertion(()-> Assertions.assertThat(columnHeaders)
.as(String.format("Column %s not found", column))
.contains(column));

return columnHeaders.indexOf(column) +1;
}

private String getPermissionTableValue(int row, int col)
{
return ((Locator.XPathLocator)getSimpleTableCell(Locator.id("category-security"), row, col)).child("div").child("a").child("input").findElement(getDriver())
Expand Down Expand Up @@ -2173,14 +2186,18 @@ public void categoryPermissionsUI() throws Exception
Assertions.assertThat(categoryRows.keySet()).as("Custom categories")
.containsExactlyElementsOf(categories);

click(Locator.id("a_all_-3")); // All Categories for Guests
Locator allGuestCategoriesDropdownLoc = Locator.id("a_all_-3");
shortWait().until(ExpectedConditions.elementToBeClickable(allGuestCategoriesDropdownLoc));
click(allGuestCategoriesDropdownLoc); // All Categories for Guests
clickRoleInOpenDropDown("SND Reader");

int guestColIndex = getPermissionTableColumnIndex("Guests");

for (Integer r : categoryRows.values())
{
// Wait for setting to propagate
Awaitility.await().atMost(Duration.ofSeconds(1)).untilAsserted(() ->
assertEquals("SND Reader", getPermissionTableValue(r, 1)));
assertEquals("SND Reader", getPermissionTableValue(r, guestColIndex)));
}

findButton("Clear All").click();
Expand All @@ -2191,7 +2208,7 @@ public void categoryPermissionsUI() throws Exception
Integer row = categoryRows.get(category);
String value = getPermissionTableValue(row, 1);
assertEquals("None", value);
click(getSimpleTableCell(Locator.id("category-security"), row, 1));
click(getSimpleTableCell(Locator.id("category-security"), row, guestColIndex));
clickRoleInOpenDropDown(permissions.get(categories.indexOf(category)));
}

Expand All @@ -2200,7 +2217,7 @@ public void categoryPermissionsUI() throws Exception
for (String category : categories)
{
Integer row = categoryRows.get(category);
String value = getPermissionTableValue(row, 1);
String value = getPermissionTableValue(row, guestColIndex);
assertEquals(permissions.get(categories.indexOf(category)), value);
}

Expand Down