Update column names and disable time zone shifting for HDRLTest #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-danield
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
I figured out why this started failing on TeamCity. It requires dataintegration, so doesn't run in community suites but this repository wasn't included in the premium suites until recently. After adding this repo to the premium suites and it revealed a couple of problems with this test.
The forms in this module don't handle time zone shifting correctly. This is similar to the problems we have with EHR Ext forms. Like those tests, the fix is to disable time zone shifting for the test.
DataRegionTableno longer compensates for missing spaces when referencing columns by label. I've updated the test to use the columns' names instead.Related Pull Requests
Changes