Skip to content

Remove unnecessary HttpView.currentView() casts in JSPs #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Apr 7, 2025
Merged

Remove unnecessary HttpView.currentView() casts in JSPs #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hdrl/src/org/labkey/hdrl/view/editRequest.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}
%>
<%
JspView<HDRLController.RequestForm> me = (JspView<HDRLController.RequestForm>)HttpView.currentView();
JspView<HDRLController.RequestForm> me = HttpView.currentView();
ViewContext ctx = getViewContext();
Container c = getContainer();
User user = getUser();
Expand Down
2 changes: 1 addition & 1 deletion hdrl/src/org/labkey/hdrl/view/sensitiveData.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<%@ page extends="org.labkey.api.jsp.JspBase" %>
<%@ taglib prefix="labkey" uri="http://www.labkey.org/taglib" %>
<%
JspView<HDRLController.SensitiveDataForm> sensitiveDataFormJspView = (JspView<HDRLController.SensitiveDataForm>)HttpView.currentView();
JspView<HDRLController.SensitiveDataForm> sensitiveDataFormJspView = HttpView.currentView();
HDRLController.SensitiveDataForm bean = sensitiveDataFormJspView.getModelBean();
String timeWindow = String.valueOf(bean.getTimeWindowInDays());
%>
Expand Down
2 changes: 1 addition & 1 deletion pepdb/src/org/scharp/atlas/pepdb/view/importPeptides.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<%@ page extends="org.labkey.api.jsp.JspBase" %>
<div>
<%
JspView<FileForm> me = (JspView<FileForm>) HttpView.currentView();
JspView<FileForm> me = HttpView.currentView();
FileForm bean = me.getModelBean();
%>
<labkey:errors/>
Expand Down
2 changes: 1 addition & 1 deletion pepdb/src/org/scharp/atlas/pepdb/view/importPools.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<%@ page extends="org.labkey.api.jsp.JspBase" %>
<div>
<%
JspView<PepDBController.FileForm> me = (JspView<PepDBController.FileForm>) HttpView.currentView();
JspView<PepDBController.FileForm> me = HttpView.currentView();
PepDBController.FileForm bean = me.getModelBean();
%>

Expand Down
2 changes: 1 addition & 1 deletion pepdb/src/org/scharp/atlas/pepdb/view/peptideDetails.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<%@ page import="org.scharp.atlas.pepdb.model.Source" %>
<%@ page extends="org.labkey.api.jsp.JspBase" %>
<%
JspView<PeptideQueryForm> me = (JspView<PeptideQueryForm>) HttpView.currentView();
JspView<PeptideQueryForm> me = HttpView.currentView();
PeptideQueryForm bean = me.getModelBean();
%>
<table>
Expand Down
2 changes: 1 addition & 1 deletion pepdb/src/org/scharp/atlas/pepdb/view/peptideGroupSelect.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<%@ page import="org.scharp.atlas.pepdb.model.ProteinCategory" %>
<%@ page extends="org.labkey.api.jsp.JspBase" %>
<%
JspView<PeptideQueryForm> me = (JspView<PeptideQueryForm>) HttpView.currentView();
JspView<PeptideQueryForm> me = HttpView.currentView();
PeptideQueryForm bean = me.getModelBean();
if(bean.getMessage() != null){
%>
Expand Down