Skip to content

Rename SaveRowsResponse to RowsResponse #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 1 commit into from
Jul 18, 2025
Merged

Rename SaveRowsResponse to RowsResponse #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions OConnorExperiments/test/src/org/labkey/test/tests/OConnorExperimentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.labkey.remoteapi.query.DeleteRowsCommand;
import org.labkey.remoteapi.query.Filter;
import org.labkey.remoteapi.query.InsertRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.remoteapi.query.SelectRowsCommand;
import org.labkey.remoteapi.query.SelectRowsResponse;
import org.labkey.remoteapi.query.UpdateRowsCommand;
Expand Down Expand Up @@ -274,7 +274,7 @@ protected void insertViaJavaApi()
Connection cn = WebTestHelper.getRemoteApiConnection();
InsertRowsCommand insertCmd = new InsertRowsCommand(SCHEMA_NAME, TABLE_NAME);
insertCmd.addRow(rowMap);
SaveRowsResponse resp = insertCmd.execute(cn, getProjectName());
RowsResponse resp = insertCmd.execute(cn, getProjectName());
for (int i = 0; i < insertCmd.getRows().size(); i++)
{
Map<String, Object> row = resp.getRows().get(i);
Expand All @@ -301,7 +301,7 @@ protected void updateViaJavaApi()
rowMap.put("Description", "API Description Edited");
rowMap.put("ExperimentType", "API Type Edited");
Connection cn = WebTestHelper.getRemoteApiConnection();
SaveRowsResponse resp = cmd.execute(cn, getProjectName());
RowsResponse resp = cmd.execute(cn, getProjectName());
assertEquals("Expected to update " + rowMap.size() + " rows", rowMap.size(), resp.getRowsAffected().intValue());
goToProjectHome();
}
Expand Down Expand Up @@ -329,7 +329,7 @@ protected void deleteViaJavaApi()
for (String pk : pkeys)
cmd.addRow(Collections.singletonMap("container", pk));

SaveRowsResponse resp = cmd.execute(cn, getProjectName());
RowsResponse resp = cmd.execute(cn, getProjectName());
assertEquals("Expected to delete " + pkeys.size() + " rows", pkeys.size(), resp.getRowsAffected().intValue());

SelectRowsCommand selectCmd = new SelectRowsCommand(SCHEMA_NAME, TABLE_NAME);
Expand Down
4 changes: 2 additions & 2 deletions genotyping/test/src/org/labkey/test/tests/GenotypingBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.labkey.remoteapi.CommandException;
import org.labkey.remoteapi.Connection;
import org.labkey.remoteapi.query.DeleteRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.TestFileUtils;
Expand Down Expand Up @@ -135,7 +135,7 @@ private void deleteTemplateRow(boolean failOnError)
Connection cn = WebTestHelper.getRemoteApiConnection();
DeleteRowsCommand cmd = new DeleteRowsCommand("genotyping", "IlluminaTemplates");
cmd.addRow(Collections.singletonMap("Name", TEMPLATE_NAME));
SaveRowsResponse resp;
RowsResponse resp;
try
{
resp = cmd.execute(cn, getProjectName());
Expand Down