PanoramaPublic bug fixes #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix NPE in PrivateDataReminderJob when a submitted experiment has no associated announcementId. - Allow re-submitting data that is already public but not yet published in a peer-reviewed journal (ExperimentAnnotations.isFinal()) e.g., manuscript on bioRxiv or medRxiv. - Remove logic that prevented making data public when full publication details were entered at submission time but the data was kept private. - Do not send private data reminders for datasets that may have been resubmitted and are pending copy.
…been resubmitted and are pending copy. - Include experiment title in the private data reminder message - Updated PanoramaPublicMakePublicTest to verify that data pending copy cannot be made public by entering the MakePublicAction URL in the browser.
labkey-jeckels
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PrivateDataReminderJobwhen a submitted experiment has no associatedannouncementId.PanoramaPublicMakePublicTestto verify that data pending copy cannot be made public by entering the MakePublicAction URL in the browser