Skip to content

Don't interfere with failure screenshots with @After #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 2 commits into from
Nov 5, 2025
Merged

Don't interfere with failure screenshots with @After #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e2c4d9
Don't interfere with failure screenshots with @After
labkey-tchad Nov 4, 2025
1fcb619
Specify data region name
labkey-tchad Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions panoramapublic/test/src/org/labkey/test/tests/panoramapublic/PanoramaPublicBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.labkey.test.Locator;
import org.labkey.test.TestFileUtils;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.WebTestHelper;
import org.labkey.test.components.BodyWebPart;
import org.labkey.test.components.SubfoldersWebPart;
import org.labkey.test.components.panoramapublic.TargetedMsExperimentInsertPage;
Expand Down Expand Up @@ -113,10 +114,6 @@ public static void initProject()
@After
public void afterTest() throws IOException, CommandException
{
if (isImpersonating())
{
stopImpersonating();
}
verifySymlinks();
}

Expand Down Expand Up @@ -149,7 +146,7 @@ private void createPanoramaPublicJournalProject()

boolean verifySymlinks() throws IOException, CommandException
{
Connection connection = createDefaultConnection();
Connection connection = WebTestHelper.getRemoteApiConnection(false);
SimpleGetCommand command = new SimpleGetCommand("PanoramaPublic", "verifySymlinks");
CommandResponse verifyResponse = command.execute(connection, "/");

Expand Down
2 changes: 1 addition & 1 deletion ...amapublic/test/src/org/labkey/test/tests/panoramapublic/PanoramaPublicMyDataViewTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private void verifyColumnValues(DataRegionTable table, int catalogEntryCol, int
@NotNull
private DataRegionTable myDataView()
{
var table = new DataRegionTable.DataRegionFinder(getDriver()).refindWhenNeeded();
var table = new DataRegionTable("Targeted MS Experiment List", getDriver());
assertTrue(table.hasHeaderMenu("My Data"));
table.clickHeaderButtonAndWait("My Data");
return new DataRegionTable.DataRegionFinder(getDriver()).refindWhenNeeded();
Expand Down