Redirect to ActionURL instead of a String URL #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pView.redirect(String) with HttpView.redirect(URLHelper). - Remove lookup for "sender" parameter in DeleteSupplementAction and UpdatePropertyAction, since it is not included in the request. - Use getActionURL() as the value of "sender" parameter instead of request.getRequestURL(). - Avoid HTML-escaping URLs in JavaScript contexts
labkey-adam
approved these changes
Jul 29, 2025
labkey-jeckels
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HttpView.redirect(String)withHttpView.redirect(URLHelper).DeleteSupplementActionandUpdatePropertyAction, since it is not included in the request.getActionURL()as the value of "sender" parameter instead ofrequest.getRequestURL().