fix(SandboxSynth): pass index to unison voices forEach#170
Merged
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom Apr 20, 2026
Merged
fix(SandboxSynth): pass index to unison voices forEach#170mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
voices.forEach(voice => {...})atcomponents/audio/InstrumentSandbox/SandboxSynth.js:782was missing the index argument, but the body still referencedifrom an earlierfor (let i...)loop used to build thevoicesarray.ReferenceError: i is not definedwhen starting a unison voice — reproduced by a tester entering Arco from the Studio modal.for (let i...)loops in the body each declare their owni, so no shadowing.Worth manually verifying: open the Studio modal, select Arco, play a note, and confirm no runtime error. With
unisonVoices > 1, check that the[SandboxSynth] Started voice N (k/numVoices)log lines report correct indices.