Implementation of corrections for projection effects [version:1.0.11]#88
Open
eduardojsbarroso wants to merge 13 commits into
Open
Implementation of corrections for projection effects [version:1.0.11]#88eduardojsbarroso wants to merge 13 commits into
eduardojsbarroso wants to merge 13 commits into
Conversation
Add Costanzi19 projection model and binned_grid skeleton
…py. Add function comments. Clean the code by isort and black
Implement Costanzi binned and unbinned projection-effect probability calculations for Gaussian richness-mass relations. Add recipe support for projection-effect grid construction and cache handling. Update tests for binned probabilities, unbinned PDFs, mass-redshift meshing, and projection recipe grid construction.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 98.41% 97.99% -0.42%
==========================================
Files 28 32 +4
Lines 1826 2341 +515
Branches 60 89 +29
==========================================
+ Hits 1797 2294 +497
- Misses 29 47 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for projection effects in CROW, including a Costanzi-style projected richness model and an optional projection-induced lensing profile correction for stacked DeltaSigma predictions.
Main Changes:
crow.cluster_modules.projection_effectsmodule.CostanziBaseModel,CostanziBinned, andCostanziUnBinnedfor projected observed-richness probabilities.CostanziLensingBias/bselfor multiplicative selection-bias corrections to stacked DeltaSigma profiles.GridBinnedClusterRecipe.notebooks/run_projection.ipynb.Implementation Notes:
h.