Skip to content

feat: add support for group address validation in user-exists map and implement group validation logic#302

Merged
maneeshaxyz merged 2 commits intoLSFLK:mainfrom
Aravinda-HWK:300-feature-support-group-email-accept-in-the-socketmap-service
Mar 18, 2026
Merged

feat: add support for group address validation in user-exists map and implement group validation logic#302
maneeshaxyz merged 2 commits intoLSFLK:mainfrom
Aravinda-HWK:300-feature-support-group-email-accept-in-the-socketmap-service

Conversation

@Aravinda-HWK
Copy link
Collaborator

@Aravinda-HWK Aravinda-HWK commented Mar 18, 2026

📌 Description

To support group emails, the socketmap service is checking the groups from the IDP and validating the existence of the group in the correct domain.


🔍 Changes Made

  • Create a group.go file to check the group existence from the IDP(use the existence auth to get the bearer token)
  • Update the README.md file

✅ Checklist (Email System)

  • Core services tested (SMTP, IMAP, mail storage, end-to-end delivery)
  • Security & compliance verified (auth via Thunder IDP, TLS, DKIM/SPF/DMARC, spam/virus filtering)
  • Configuration & deployment checked (configs generated, Docker/Compose updated)
  • Reliability confirmed (error handling, logging, monitoring)
  • Documentation & usage notes updated (README, deployment, API)

🧪 Testing Instructions


📷 Screenshots / Logs (if applicable)


⚠️ Notes for Reviewers

Create a group in Thunder, and the group email address will be <group_name>-group@<domain_name>.

@Aravinda-HWK Aravinda-HWK self-assigned this Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the socketmap service by integrating group email address validation with the existing user validation mechanism. It allows the service to check for the existence of group addresses, formatted as -group@, against the Thunder IDP, ensuring that group-based email routing and permissions are correctly handled. This change expands the utility of the user-exists map to cover both individual users and designated group addresses.

Highlights

  • Group Address Validation: Implemented support for validating group email addresses using the Thunder IDP within the user-exists socketmap.
  • Dedicated Group Logic: Introduced a new group.go file containing the ValidateGroupAddress function to specifically handle group existence checks.
  • Documentation Update: Updated the README.md to reflect the new group address validation capability and format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for group address validation by introducing a new group.go file for validation logic and updating the user-exists handler to check for groups if a user is not found. The changes are well-structured and the documentation in README.md is updated accordingly. I have one suggestion to improve code maintainability in the new group.go file by reducing code duplication.

Copy link
Member

@maneeshaxyz maneeshaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maneeshaxyz maneeshaxyz merged commit 57b7c90 into LSFLK:main Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support group email accept in the socketmap service

2 participants