feat: add support for group address validation in user-exists map and implement group validation logic#302
Conversation
… implement group validation logic
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for group address validation by introducing a new group.go file for validation logic and updating the user-exists handler to check for groups if a user is not found. The changes are well-structured and the documentation in README.md is updated accordingly. I have one suggestion to improve code maintainability in the new group.go file by reducing code duplication.
📌 Description
To support group emails, the socketmap service is checking the groups from the IDP and validating the existence of the group in the correct domain.
🔍 Changes Made
group.gofile to check the group existence from the IDP(use the existence auth to get the bearer token)README.mdfile✅ Checklist (Email System)
🧪 Testing Instructions
📷 Screenshots / Logs (if applicable)
Create a group in Thunder, and the group email address will be <group_name>-group@<domain_name>.