Improve QPS values argument processing#34
Merged
Siddhant-Ray merged 1 commit intoLMCache:mainfrom Nov 24, 2025
Merged
Conversation
Refactor QPS value handling to join and split arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors QPS value handling to correctly support multiple float inputs.
Previously, when multiple QPS values were passed (e.g., "1.34 2.0 3.0"), the script treated them as a single string argument, causing an invalid float value error in sharegpt-qa.py.
The updated logic joins all remaining arguments ("${*:4}") and then splits them using IFS, ensuring that each QPS value is parsed as an individual float.
This makes the benchmark script compatible with multiple QPS inputs and prevents the argparse parsing error.