feat(gateway): /add_worker shim that accepts URL via query string + worker_type#17
Open
DavidBellamy wants to merge 19 commits intomainfrom
Open
feat(gateway): /add_worker shim that accepts URL via query string + worker_type#17DavidBellamy wants to merge 19 commits intomainfrom
DavidBellamy wants to merge 19 commits intomainfrom
Conversation
…alistic perf and auto-discover ut (sgl-project#22086) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com>
…gl-project#21649) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com>
…orker_type Adds a miles_add_worker HTTP handler to sgl-model-gateway/src/server.rs that accepts the URL-as-query-string format Miles uses to register workers, and translates it into the gateway's standard JSON-body WorkerConfigRequest. Also handles PD-disaggregation worker types (prefill/decode/regular) once LLM360/miles#990 lands the corresponding client-side change. Miles speaks a different request convention than the gateway expects. This adapter avoids a Miles-side change for every gateway-side API tweak, and lets PD-disaggregation worker registration flow through the same create_worker service path as the JSON-body endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a `miles_add_worker` HTTP handler to `sgl-model-gateway/src/server.rs` that accepts the URL-as-query-string format Miles uses to register workers, and translates it into the gateway's standard JSON-body `WorkerConfigRequest`. Also handles PD-disaggregation worker types (`prefill` / `decode` / `regular`) once `LLM360/miles#990` lands the corresponding client-side change.
Why
Miles speaks a different request convention than the gateway expects. This adapter avoids a Miles-side change for every gateway-side API tweak, and lets PD-disaggregation worker registration flow through the same `create_worker` service path as the JSON-body endpoint.
Changes
Test plan
Provenance
One of five focused PRs that supersede #3.