Skip to content

fix(rollout): guard round(None) in zero-std metric aggregation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidBellamy wants to merge 1 commit into from
Closed

fix(rollout): guard round(None) in zero-std metric aggregation #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion miles/ray/rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,10 +1260,18 @@ def _is_zero_std(samples: list[Sample]):
rewards = [sample.get_reward_value(args) for sample in samples]
return len(rewards) == 0 or all(rewards[0] == r for r in rewards)

def _reward_label(sample: Sample) -> str:
# Aborted / None-reward samples have no numeric reward to round; bucket
# them under a dedicated label so downstream round() never sees None.
reward = sample.get_reward_value(args)
if reward is None:
return "none"
return str(round(reward, 1))

all_sample_groups = group_by(all_samples, lambda s: s.group_index)
interesting_sample_groups = [g for g in all_sample_groups.values() if _is_zero_std(g)]

interesting_rewards = [str(round(g[0].get_reward_value(args), 1)) for g in interesting_sample_groups]
interesting_rewards = [_reward_label(g[0]) for g in interesting_sample_groups]

return {f"zero_std/count_{reward}": len(items) for reward, items in group_by(interesting_rewards).items()}

Expand Down
Loading