Skip to content

Comments

privacy-mode: proposed changes#95

Merged
Garandor merged 2 commits intofeature/NODE-4814-privacy-mode-v2from
privmode_changes
Jan 29, 2026
Merged

privacy-mode: proposed changes#95
Garandor merged 2 commits intofeature/NODE-4814-privacy-mode-v2from
privmode_changes

Conversation

@Garandor
Copy link
Contributor

No description provided.

@Garandor Garandor marked this pull request as ready for review January 29, 2026 16:19
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Garandor Garandor changed the title proposed changes privacy-mode: proposed changes Jan 29, 2026
@Garandor Garandor requested a review from GTC6244 January 29, 2026 16:22
Copy link
Contributor

@GTC6244 GTC6244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with all of them - though the “contains” when search tag should probably still be an “endswith”, but the likelyhood of those charactesr appearing randomly is slim to none.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

PASS [ 44.583s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency
PASS [ 44.843s] (2/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_single_link
PASS [ 87.667s] (1/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_all_links

@Garandor Garandor merged commit 529ef64 into feature/NODE-4814-privacy-mode-v2 Jan 29, 2026
28 of 29 checks passed
@Garandor Garandor deleted the privmode_changes branch January 29, 2026 16:40
Garandor added a commit that referenced this pull request Jan 29, 2026
* works

* cargo fmt

* Update rust/lit-core/lit-observability/Cargo.toml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update rust/lit-core/lit-api-core/src/context/mod.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update rust/lit-core/lit-observability/src/logging/privacy_filter.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update cargo locks and privacy mode logic in lit-api-core

* privacy-mode: proposed changes (#95)

* proposed changes

* count privacy mode requests received via otel

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Adam Reif <adam@litprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants